[Box Backup-commit] COMMIT r1466 - box/chris/merge/lib/server

boxbackup-dev@fluffy.co.uk boxbackup-dev@fluffy.co.uk
Sat, 24 Mar 2007 21:51:58 +0000


Author: chris
Date: 2007-03-24 21:51:58 +0000 (Sat, 24 Mar 2007)
New Revision: 1466

Modified:
   box/chris/merge/lib/server/WinNamedPipeStream.cpp
Log:
Use memmove() for overlapping source and destination buffer. Thanks to
Charles Lecklider for pointing this out. (refs #3, merges [1442])


Modified: box/chris/merge/lib/server/WinNamedPipeStream.cpp
===================================================================
--- box/chris/merge/lib/server/WinNamedPipeStream.cpp	2007-03-24 21:50:37 UTC (rev 1465)
+++ box/chris/merge/lib/server/WinNamedPipeStream.cpp	2007-03-24 21:51:58 UTC (rev 1466)
@@ -293,7 +293,7 @@
 		}
 
 		memcpy(pBuffer, mReadBuffer, BytesToCopy);
-		memcpy(mReadBuffer, mReadBuffer + BytesToCopy, BytesRemaining);
+		memmove(mReadBuffer, mReadBuffer + BytesToCopy, BytesRemaining);
 
 		mBytesInBuffer = BytesRemaining;
 		NumBytesRead = BytesToCopy;