[Box Backup-dev] Re: [Box Backup] Win32 port

Chris Wilson boxbackup-dev@fluffy.co.uk
Mon, 5 Dec 2005 23:37:29 +0000 (GMT)


Hi Ben,

>>  9. Ditto for the check for a null buffer pointer before freeing it in
>>     BackupStoreFileCombine.cpp
>> 
>>  10. Someone else should review Nick's changes to BackupStoreFile.cpp, as I
>>     don't understand the alignment restrictions that his CodingChunkAlloc
>>      is enforcing, nor how the call to MaxBlockSizeForChunkSize can be
>>      replaced with a fixed size of 256.
>
> I will do that tomorrow.

No need to review either of these - they're already in 0.09.

Cheers, Chris.
-- 
_ ___ __     _
  / __/ / ,__(_)_  | Chris Wilson <0000 at qwirx.com> - Cambs UK |
/ (_/ ,\/ _/ /_ \ | Security/C/C++/Java/Perl/SQL/HTML Developer |
\ _/_/_/_//_/___/ | We are GNU-free your mind-and your software |