[Box Backup-dev] Reviewing code -- help!

Chris Wilson boxbackup-dev@fluffy.co.uk
Wed, 7 Dec 2005 12:39:59 +0000 (GMT)


Hi Ben,

> I sat down to start reviewing the code, and I'm now a bit confused. I'm not 
> entirely sure which bits are what, and what should be reviewed.
>
> I would help me enormously if the contributors could post a list of svn diff 
> commands which will show the proposed changes in the most easily reviewed 
> way.

Martin beat me to it :-)

> I should have quite a bit of time today to review it. Much of it is going to 
> be spent installing and compiling Linux then making it do stuff, which is 
> always uncomfortable for *BSD types getting to grips with the myriad versions 
> of kernels and distributions.

I'd recommend a default install of Fedora Core 4. It's easy and Box should 
work out of the box - if ti doesn't, then it needs to be fixed.

However, I'm developing on Fedora Core 2.

> BTW, am I right in thinking that the aim to get all the Win32 stuff merged 
> into trunk in a way which doesn't break POSIX, but may or may not work 
> properly under Win32. Then fix Win32?

I'd be very happy with that plan. My 02-compile-on-cygwin branch 
[http://bbdev.fluffy.co.uk/svn/box/chris/win32/merge/02-compile-on-cygwin/] 
should compile on any *nix as far as I know.

For diffs, compare with 
[http://bbdev.fluffy.co.uk/svn/box/chris/win32/merge/00-martins-original-autoconf/]

Cheers, Chris.
-- 
_ ___ __     _
  / __/ / ,__(_)_  | Chris Wilson <0000 at qwirx.com> - Cambs UK |
/ (_/ ,\/ _/ /_ \ | Security/C/C++/Java/Perl/SQL/HTML Developer |
\ _/_/_/_//_/___/ | We are GNU-free your mind-and your software |