[Box Backup-dev] 07-win32-fixes

[Chris Wilson]

Hi Ben,

> test/basicserver/testbasicserver.cpp
> 	- is this a misplaced change -- you said tests didn't work...

I intend to fix it, but it doesn't work yet. It's not plugged into the 
test architecture yet, I hope, so it shouldn't cause problems.

> docs/backup/encrypt_rsync.txt
> 	- conflicts with diffopt?

Sorry, could you explain that for me?

> There are a few lines like these:
>
> Property changes on: lib/win32/WinNamedPipeStream.cpp
> ___________________________________________________________________
> Name: svn:executable
>   + *
>
> what's that about?

It looks like a number of files were set to executable by default by svn, 
and I hadn't noticed before. I'll try to sort them out tomorrow.

> Other than that, I'm happy for this to go into truck. But I'm not sure what 
> changes (if any) are needed to respond to Charles' comments.

I would like to implement his suggestions about the client open mode and 
the security descriptor. I will try to find time tomorrow, but if not, can 
they be merged later?

> Would Martin like to give it a sanity check and merge it in? (seeing as 
> Martin has somehow ended up as the project merger...)

That would be great! :-) Martin, please let me know when you are done, and 
I'll take a cut from your new trunk.

Cheers, Chris.
-- 
_ ___ __     _
  / __/ / ,__(_)_  | Chris Wilson <0000 at qwirx.com> - Cambs UK |
/ (_/ ,\/ _/ /_ \ | Security/C/C++/Java/Perl/SQL/HTML Developer |
\ _/_/_/_//_/___/ | We are GNU-free your mind-and your software |