[Box Backup-dev] 07-win32-fixes

[Ben Summers]

On 12 Dec 2005, at 01:00, Chris Wilson wrote:

> Hi Ben,
>
>> test/basicserver/testbasicserver.cpp
>> 	- is this a misplaced change -- you said tests didn't work...
>
> I intend to fix it, but it doesn't work yet. It's not plugged into  
> the test architecture yet, I hope, so it shouldn't cause problems.

OK, it just seemed a minor change which didn't have much to do with  
win32.

>
>> docs/backup/encrypt_rsync.txt
>> 	- conflicts with diffopt?
>
> Sorry, could you explain that for me?

The diffopt patch (which has been applied to trunk) also modifies  
that file -- does this patch overwrite those changes, losing the  
notes on the optimised code?

[snip]
>
>> Other than that, I'm happy for this to go into truck. But I'm not  
>> sure what changes (if any) are needed to respond to Charles'  
>> comments.
>
> I would like to implement his suggestions about the client open  
> mode and the security descriptor. I will try to find time tomorrow,  
> but if not, can they be merged later?

Of course. The most important thing is to get everything into trunk.

>
>> Would Martin like to give it a sanity check and merge it in?  
>> (seeing as Martin has somehow ended up as the project merger...)
>
> That would be great! :-) Martin, please let me know when you are  
> done, and I'll take a cut from your new trunk.

Thanks for all your hard work. Sounds like the threading thing was a  
bit of a nightmare.

Tip to compiler writers: If you have a mode where a certain set of  
functions will cause the program to crash, you might want to consider  
detecting this and outputting warnings. Especially if that mode is  
the default.

Ben