[Box Backup-dev] COMMIT r237 - box/chris/boxi/lib/server

Ben Summers boxbackup-dev@fluffy.co.uk
Thu, 15 Dec 2005 13:16:54 +0000


On 15 Dec 2005, at 13:11, Chris Wilson wrote:

> Hi Ben,
>
>> I believe this change is misleading, and messages regarding  
>> account corruption should be restricted to the server and only  
>> emitted when there is an actual problem which has been detected by  
>> the code.
>
> Why is it misleading?

In most cases the store is not corrupt.

> There are plenty of cases where TLSReadFailed can be caused by  
> problems on the server rather than network problems (my previous  
> patch fixes just one) and what use are reason messages that send  
> the user (or admin) down the wrong garden path, looking for network  
> problems where none exist?
>
>> This is just going to worry users unnecessarily.
>
> How about "or a problem with the server"?

That would be better.

Ben