[Box Backup-dev] COMMIT r255 - in box/chris/win32/vc2005-compile-fixes/lib: common compress server win32

[Chris Wilson]

Hi Ben,

> Eeek. You need to be careful with that -- IOStream and it's subclasses are 
> rather fundamental. I think your changes will break 64 bit platforms as 
> CollectInBufferStream hasn't had all it's function signatures changed int to 
> size_t.

Yeah, that was a mistake, sorry. I was about to change it to size_t like 
the others.

> I deliberately used int for sizes in IOStream functions, as I thought these 
> frequently used functions should use arithmetic on the most natural integer 
> size for the platform.

I don't understand why you used a signed rather than an unsigned type for 
things which don't seem to make any sense as negatives, like buffer sizes. 
But I could use IOStream::pos_type instead if you prefer, or even make 
everything use signed integers if you insist.

Cheers, Chris.
-- 
_ ___ __     _
  / __/ / ,__(_)_  | Chris Wilson <0000 at qwirx.com> - Cambs UK |
/ (_/ ,\/ _/ /_ \ | Security/C/C++/Java/Perl/SQL/HTML Developer |
\ _/_/_/_//_/___/ | We are GNU-free your mind-and your software |