[Box Backup-dev] COMMIT r255 - in box/chris/win32/vc2005-compile-fixes/lib: common compress server win32

Martin Ebourne boxbackup-dev@fluffy.co.uk
Wed, 21 Dec 2005 00:36:16 +0000


On Wed, 2005-12-21 at 00:10 +0000, Chris Wilson wrote:
> Hi Martin,
> 
> >> -#include <unistd.h>
> >> +#ifndef WIN32
> >> +#include <unistd.h>
> >> +#endif
> >
> > Please don't use a platform check for header files. Please add a
> > configure test (AC_CHECK_HEADERS) and use its define.
> 
> Even though configure doesn't run on win32?

configure should run under cygwin, which I thought was the idea.

Presumably you've tried that since there's stuff for win32 in configure.ac.

Cheers,

Martin.