[Box Backup-dev] Win32 port

Chris Wilson boxbackup-dev@fluffy.co.uk
Fri, 23 Dec 2005 13:50:39 +0000 (GMT)


Hi Ben,

> I'll try and review all the changes you made soon. I'm still a bit dubious 
> about the type changes, and the impact it might have on the POSIX side. I 
> trust you've tried to compile it on a POSIX box?

I'm a bit dubious about the type changes too - I had to revert one of them 
because it needed to store a negative integer (in FdGetLine). Feel free to 
ignore them for now, and just apply the other changes.

I think the typecasts are OK - they're just making the implicit casts 
explicit to keep VC happy. It might be worth reviewing the code around 
them to see whether the assumptions about sizes and signedness are 
justified or should be made explicit with assertions or other checks.

Cheers, Chris.
-- 
_ ___ __     _
  / __/ / ,__(_)_  | Chris Wilson <0000 at qwirx.com> - Cambs UK |
/ (_/ ,\/ _/ /_ \ | Security/C/C++/Java/Perl/SQL/HTML Developer |
\ _/_/_/_//_/___/ | We are GNU-free your mind-and your software |