[Box Backup-dev] Win32 port

[Ben Summers]

On 23 Dec 2005, at 13:50, Chris Wilson wrote:

> Hi Ben,
>
>> I'll try and review all the changes you made soon. I'm still a bit  
>> dubious about the type changes, and the impact it might have on  
>> the POSIX side. I trust you've tried to compile it on a POSIX box?
>
> I'm a bit dubious about the type changes too - I had to revert one  
> of them because it needed to store a negative integer (in  
> FdGetLine). Feel free to ignore them for now, and just apply the  
> other changes.
>
> I think the typecasts are OK - they're just making the implicit  
> casts explicit to keep VC happy. It might be worth reviewing the  
> code around them to see whether the assumptions about sizes and  
> signedness are justified or should be made explicit with assertions  
> or other checks.

I think it's worth reviewing the code. It really should be happy on  
all 'sane' compilers, and these could be bugs. On the other hand, it  
could just be making the code far more ugly.

Ben