[Box Backup-dev] Where to put my bug fixes?
Martin Ebourne
boxbackup-dev@fluffy.co.uk
Sun, 06 Aug 2006 02:44:42 +0100
On Sat, 2006-08-05 at 19:10 +0100, Chris Wilson wrote:
> Could I have permission from the development team (especially Ben and
> Martin) to merge any of my Win32 patches, under any conditions? For
> example, anything clearly enclosed in #ifdef WIN32?
I'd like to apologise for being silent on your proposed patches so far.
I glanced at them and decided there was rather a lot so I thought I'd
come back to it - assuming I found some time! It would be daft to not
merge changes after the hard work has been put in, just for lack of
review, so it is important to find the time somehow.
One thing that would help is knowing what all of the individual changes
are. It's generally easier to review small self contained groups of
related changes together rather than a whole branch with lots happening.
You don't need to make branches, but if you could just list SVN
revisions you'd like to merge, grouped together where appropriate, that
would help. When I looked before I couldn't see how you'd arrived at
what was in the merge branch, it just seemed to have sprung into
existence.
Cheers,
Martin.