[Box Backup-dev] [PATCH] Win32 merge [01] bbackupd.conf

[Chris Wilson]

Hi Martin,

On Mon, 7 Aug 2006, Martin Ebourne wrote:

>> OK, merged. (I hope this is what you reviewed :-)
>
> Er, no actually it's not!
>
> I'm a bit confused. I reviewed what was in the chris/merge branch as I
> thought you requested.

OK, sorry, I misunderstood.

> The related change in that appeared to be rename
> bbackupd.conf to bbackupd.conf.in and apply this patch:
>
> --- trunk/configure.ac	2006-08-07 22:14:16.000000000 +0100
> +++ merge/configure.ac	2006-08-07 22:12:26.000000000 +0100
> @@ -220,6 +221,7 @@
>                    lib/server/makeprotocol.pl
>                    runtest.pl
>                    test/backupstorefix/testfiles/testbackupstorefix.pl
> +                   test/bbackupd/testfiles/bbackupd.conf
>                    test/bbackupd/testfiles/extcheck1.pl
>                    test/bbackupd/testfiles/extcheck2.pl
>                    test/bbackupd/testfiles/notifyscript.pl])
>
> I can see how that works and fixes it. I don't see how the change you've
> commited fixes it though, you've not even added bbackupd.conf to the
> list of files to substitute.

Sorry, I missed that bit.

> And what you have committed doesn't match what's in your merge branch.

No, you're right, I'll revert it.

> Not sure what PERL_NATIVE is in aid of either. Can you explain it a bit? 
> Is the idea for mingw that the compile and unit tests take place under 
> unix (hence the native perl) but the exe & other scripts run under 
> windows?

Yes. bbackupd is a native process, and it needs to find a native Perl 
using a native path when calling the notify script. But in all other 
places, we are running under Cygwin, so we need a Unix path to a Cygwin 
Perl.

I'll commit the change in "chris/merge" and we can discuss the PERL_NATIVE 
change separately.

Cheers, Chris.
-- 
_ ___ __     _
  / __/ / ,__(_)_  | Chris Wilson <0000 at qwirx.com> - Cambs UK |
/ (_/ ,\/ _/ /_ \ | Security/C/C++/Java/Perl/SQL/HTML Developer |
\ _/_/_/_//_/___/ | We are GNU-free your mind-and your software |