[Box Backup-dev] COMMIT r733 - box/chris/merge/bin/bbackupd

[Martin Ebourne]

Chris Wilson <chris@qwirx.com> wrote:

> Hi Martin,
>
> Please review for merge:
>
>   svn diff -r 732:733 http://bbdev.fluffy.co.uk/svn/box/chris/merge
>
> * Win32ServiceFunctions.cpp
> - RemoveService() returns a status code, 0 for success, 1 for error
> - RemoveService() outputs better diagnostic messages on failure
> - RemoveService() code layout cleanups, makes it clearer that resources
>   are always freed.

How can we have a change in function signature and then have the cpp  
and h files in different commits?

For now I wouldn't waste any more time trying to get these commits  
consistent. Lets just get the stuff into trunk and make sure it builds  
asap. :) Going forward though, we don't want to work like this.

Ok to merge.

Cheers,

Martin.