[Box Backup-dev] Client bug when store full?

[Chris Wilson]

Hi all,

While writing unit tests for Boxi, I think I spotted a strange behaviour 
in Box Backup that seems like it might be a bug. I'd be interested to know 
what you think.

When the client is started and the store is already full, the client does 
not create BackupClientDirectoryRecords for any subdirectories, or try to 
sync them. While I can understand that we don't want to upload any files 
in this state, it does mean that the client user cannot fix the problem by 
himself by excluding some files from the backup (unless they are in the 
root of the location). Because the directories are not synced, the newly 
excluded files are not marked as deleted on the server.

I applied this patch to my copy in Boxi:

svn diff -r 368:369 
https://svn.sourceforge.net/svnroot/boxi/trunk/boxi/boxbackup/bin/bbackupd/BackupClientDirectoryRecord.cpp

and it does seem to fix the problem for me. Can anyone see any problems 
with this patch? If not, can I merge it to the trunk?

Cheers, Chris.
-- 
_ ___ __     _
  / __/ / ,__(_)_  | Chris Wilson <0000 at qwirx.com> - Cambs UK |
/ (_/ ,\/ _/ /_ \ | Security/C/C++/Java/Perl/SQL/HTML Developer |
\ _/_/_/_//_/___/ | We are GNU-free your mind-and your software |