[Box Backup-dev] Duplicate local variables

[Martin Ebourne]

On Tue, 2006-08-29 at 20:17 +0100, Chris Wilson wrote:
> Hi Martin,
> 
> This patch removes an unnecessary duplicate local variable. Please review 
> for merge.
> 
> svn diff -r 372:373 
> https://svn.sourceforge.net/svnroot/boxi/trunk/boxi/boxbackup/lib/backupstore/BackupStoreCheck.cpp

Looks ok, but in future please propose merges from the main box
repository since I've already got that checked out and it makes it a lot
easier.

Also trac has a very nice way of viewing changeset diffs eg.
  http://bbdev.fluffy.co.uk/trac/changeset/792
and you can jump off there to the files etc very easily. Can even review
changes with just a webbrowser if there's no shell or svn access.

I've been wondering if it would be a good idea to open a trac task for
merging the windows changes back. It would be a place to, well, keep
track of things! As it stands I'm concerned about missing stuff in
email.

How I think it would work is you add a comment to the task to say which
revisions you want to merge, then I or someone else can review them and
ack any which are good as is in another comment. If there are any which
need work instead I'd follow up to the mailing list because that's a
much better place to do discussions.

What do you think? The idea is if it's just requests and acks it would
have no noise and at a glance anyone would see what was outstanding. At
the moment I'm not sure if I'm up to date with all your requests, I'm
guessing I am since you haven't reminded me. :)

Cheers,

Martin.

PS. I'm on holiday next week so won't be getting much done for a week.