[Box Backup-dev] changeset [819]

Ben Summers boxbackup-dev@fluffy.co.uk
Thu, 31 Aug 2006 12:59:06 +0100


On 31 Aug 2006, at 12:35, Chris Wilson wrote:

> Hi Ben,
>
> On Thu, 31 Aug 2006, Ben Summers wrote:
>
>> I don't remember writing any 'recombinetemp' things or using the  
>> horrid << notation. What exactly is this for?
>
> You're looking at my patch which adds support for win32. The  
> original code does use recombinetemp but not <<, because it doesn't  
> need to convert ints to strings, which I do (to make unique  
> filenames for each step).
>
> As far as I understand, this is the code to produce older versions  
> of store files on demand by applying successive patches (reverse  
> diffs) to the latest version. But I'm not 100% sure, I didn't  
> analyse it in detail, I only fixed it to work on Win32 :-)

Ah, my error. Still don't like << though, but hey...

Amusingly, I'm doing quite a bit in ruby at the moment and they use  
<< as one of their important stylistic things, for arrays and in- 
place string concatenation and things. And I find myself using it. It  
feels wrong.

Ben