[Box Backup-dev] COMMIT r843 - box/chris/retry-debug/bin/bbstored

[Ben Summers]

On 31 Aug 2006, at 13:13, Chris Wilson wrote:

> Hi Ben,
>
>> Probably not important as you can't use the server for real, but  
>> this stops the server from being able to detect and prevent two  
>> writeable connections at once. Should be documented somewhere at  
>> least, in comments here. I presume the store is marked as "for  
>> tests only" on Win32?
>
> Yes, it's actually impossible with the current design, since there  
> is no fork() on Windows and the shared variable make it dangerous  
> to use threads instead. So the server runs in a single process with  
> synchronous housekeeping. But I could reinstate the locks if you  
> prefer, since they don't actually do any harm.

So why disable them then? Just adds #ifdefs which are a maintenance  
issue? Surely you're not that worried about 'efficiency' and  
'correctness' in a server which is for testing only? Or even for real  
use?

Ben