[Box Backup-dev] COMMIT r840 - box/chris/merge/bin/bbackupd

Chris Wilson boxbackup-dev@fluffy.co.uk
Thu, 31 Aug 2006 13:18:20 +0100 (BST)


Hi Ben,

> Without an associated test, this scares me.

I can write a test, I already did it for Boxi.

> There's a lot of complexity in the syncing mechanism, and I worry that 
> little changes can break it.

True, but the unit tests exercise most of it. If you can see a bit that 
they don't cover, I'll happily write a test for it.

> You've already re-written the main if statement for whether to update a 
> file or not.

Yes, but that is covered by unit tests. And you've got to admit that if 
there is a bug with the upload decision, whether introduced by me or 
carried forward, it's now about 100x easier to debug it :-)

Cheers, Chris.
-- 
_ ___ __     _
  / __/ / ,__(_)_  | Chris Wilson <0000 at qwirx.com> - Cambs UK |
/ (_/ ,\/ _/ /_ \ | Security/C/C++/Java/Perl/SQL/HTML Developer |
\ _/_/_/_//_/___/ | We are GNU-free your mind-and your software |