[Box Backup-dev] COMMIT r843 - box/chris/retry-debug/bin/bbstored

Chris Wilson boxbackup-dev@fluffy.co.uk
Thu, 31 Aug 2006 13:41:20 +0100 (BST)


Hi Ben,

On Thu, 31 Aug 2006, Ben Summers wrote:

> So why disable them then? Just adds #ifdefs which are a maintenance issue? 
> Surely you're not that worried about 'efficiency' and 'correctness' in a 
> server which is for testing only? Or even for real use?

I had to disable something because SendMessageToHousekeepingProcess() 
cannot work on Win32. I chose the route that allowed me to remove the most 
code, and hence simplify as much as possible. Perhaps that was the wrong 
decision since we all agree to minimise #ifdefs, and in this case the 
locking might be useful in future. It's probably better if I just #ifdef 
out just the lock waiting loop on Win32.

Cheers, Chris.
-- 
_ ___ __     _
  / __/ / ,__(_)_  | Chris Wilson <0000 at qwirx.com> - Cambs UK |
/ (_/ ,\/ _/ /_ \ | Security/C/C++/Java/Perl/SQL/HTML Developer |
\ _/_/_/_//_/___/ | We are GNU-free your mind-and your software |