[Box Backup-dev] changeset [819]

[Martin Ebourne]

Chris Wilson <chris@qwirx.com> wrote:
> So I would say that #ifndef WIN32 ... #endif seems to be OK, but we
> should be very cautious about #ifdef WIN32.

Depends on your point of view. #ifndef WIN32 makes it more likely that =20
a windows change breaks a unix platform. Disable stuff if it breaks =20
win32 but not otherwise.

>> Perhaps for future work you could try and use the minimum possible  =20
>> #ifdefs. For example, because you no longer have the housekeeping  =20
>> process, you ifdef out everything related. However, you could have  =20
>> left it all in, and just ifdefs out the code which does the actual  =20
>> connection and talking, and level everything else in place. Might  =20
>> not have made all that difference though.
>
> OK, will do. Would you like me to remove them?

I certainly would. Only passed the code review because I assumed you =20
needed to disable it.


> Suggestions welcome at any time, I want to improve the code and not
> make it worse.

No worries, we all know that. And things seem to be getting better as =20
we go further on here.

Cheers,

Martin.