[Box Backup-dev] COMMIT r348 - in box/chris/bb-save-state: . bin/bbackupd lib/common lib/server

[Ben Summers]

On 5 Feb 2006, at 19:49, Chris Wilson wrote:

> Hi Ben,
>
> On Sun, 5 Feb 2006, Ben Summers wrote:
>
>>>  svn diff http://bbdev.fluffy.co.uk/svn/box/trunk \
>>>   http://bbdev.fluffy.co.uk/svn/box/chris/win32/vc2005-compile-fixes
>>
>> I'm not sure that's quite right, as that diff will remove stuff  
>> from trunk. Which trunk revision was vc2005-compile-fixes copied  
>> from?
>
> I did deliberately merge all changes from the trunk into this  
> branch, to resolve any conflicts myself and reduce work for others.  
> So it should be good to go as it is.

Oh, sorry.

I don't think there is much to object to here, most of it is Win32  
stuff anyway.

lib/server/Daemon.cpp
	- we could syslog errors on non-Win32 platforms too. And indeed have  
a "both stderr and syslog" wrapper, it seems to be a common thing.

bin/bbackupquery/BackupQueries.cpp
	- we'll have to make that generic at some point

Finally, why have you changed const_iterator to iterator?


When you move the Win32 build files to contrib, remember to add it to  
the manifest file!

Thanks.

Ben