[Box Backup-dev] COMMIT r302 - in box/trunk: lib/backupclient test/bbackupd

Ben Summers boxbackup-dev@fluffy.co.uk
Fri, 6 Jan 2006 20:45:20 +0000


On 6 Jan 2006, at 16:23, subversion@fluffy.co.uk wrote:

> Author: martin
> Date: 2006-01-06 16:23:32 +0000 (Fri, 06 Jan 2006)
> New Revision: 302
>
> Modified:
>    box/trunk/lib/backupclient/BackupClientFileAttributes.cpp
>    box/trunk/test/bbackupd/testbbackupd.cpp
> Log:
> Fixes for xattr on Linux
>
> - A very unlikely failure where getxattr returns an error code the  
> first time
>   but succeeds the second time could cause buffer overrun and  
> corruption.

Would it really? While the error check is desirable, I don't see how  
it could, given that the size of the buffer is passed to lgetxattr().

Ben