[Box Backup-dev] Moving trunk to release

[Chris Wilson]

Hi Martin,

> As I can remember, there's 4 sets of changes still awaiting merging before 
> 0.10. Here is the list as I have it, please let me know of any 
> errors/omissions.
>
> 1.
>>  Fundamental type changes and missing includes, which might break some 
>>  platforms, but look correct to me, can be seen with:
>>    svn diff
>> http: //bbdev.fluffy.co.uk/svn/box/chris/win32/vc2005-compile-fixes@254
>> http: //bbdev.fluffy.co.uk/svn/box/chris/win32/type-changes
>
> I reviewed this in my mail of Fri, 20 Jan 2006 01:30:29. I'm not sure if 
> Ben reviewed these. Apart from the problems I commented on, I think the 
> rest are correct fixes which should be merged.

I agree completely with your assessment, and will fix the mistakes you 
pointed out as soon as I can.

> 2. Windows specific fixes:
>>    svn diff
>> http: //bbdev.fluffy.co.uk/svn/box/chris/win32/type-changes
>> http: //bbdev.fluffy.co.uk/svn/box/chris/win32/vc2005-compile-fixes
>
> Looking at this one, all the windows specific stuff looks fine. There are a 
> large number of casts in here as well though, which I don't really think 
> should be necessary.

They're not absolutely required, but each case generates a warning on MSVC 
that I would like to avoid, as the warnings could easily obscure real 
problems.

Although the casts may look a bit ugly in the code, they serve the 
function of reminding developers that a type change is happening that 
would otherwise be silently done by the compiler. This may help to spot 
obscure problems in future, but I guess that if you can't see any problems 
now with your eagle eye, the existing code is probably correct :-)

>>  Please have a look at the branch I created for SSL keepalives, and let
>>  me know if there's anything blocking it from inclusion:
>>    svn diff -r 323:326 \
>>    http://bbdev.fluffy.co.uk/svn/box/chris/diff-timeout-and-ssl-keepalive
>
> Ben has ok'd this so Chris can go ahead and merge this one.

Thanks, I will take that as permission to merge it to the trunk :-)

> 4. Save state for restart
>
> Am I right in thinking this one is not yet in svn?

Not yet in SVN, no.

Please also consider applying the (pretty trivial) fixes that I made 
before releasing the 0.10 RC 0.1, and in response to a bug report for that 
version:

svn diff http://bbdev.fluffy.co.uk/svn/box/trunk@327 \
   http://bbdev.fluffy.co.uk/svn/box/chris/boxbackup-0.10_rc0.2_win32@335

The timestamp fixes here are probably duplicated in the VS2005 fixes.

Cheers, Chris.
-- 
_ ___ __     _
  / __/ / ,__(_)_  | Chris Wilson <0000 at qwirx.com> - Cambs UK |
/ (_/ ,\/ _/ /_ \ | Security/C/C++/Java/Perl/SQL/HTML Developer |
\ _/_/_/_//_/___/ | We are GNU-free your mind-and your software |