[Box Backup-dev] COMMIT r348 - in box/chris/bb-save-state: . bin/bbackupd lib/common lib/server

[Ben Summers]

On 29 Jan 2006, at 22:18, Chris Wilson wrote:

> Hi Ben,
>
>> Looks like you're there! What's the final diff for review?
>
> svn diff -r 336:349 http://bbdev.fluffy.co.uk/svn/box/chris/bb-save- 
> state

I would have removed the operator overloading from Archive, and  
personally would have just required that classes derived from Archive  
only provide Read(void*,int length) and Write(void*,int length)  
functions, rather than doing absolutely everything, and made base  
class Get and Put inline functions which call those.

bin/bbackupd/BackupClientDirectoryRecord.h
bin/bbackupd/BackupDaemon.h
lib/common/ExcludeList.h
	-- #include "Archive.h" -> class Archive;  ?

bin/bbackupd/BackupDaemon.cpp
bin/bbackupd/BackupClientDirectoryRecord.cpp
	-- I've spotted some >> and <<'s!

I'm probably being too picky here. I wonder what Martin thinks.


>
>> Thanks for all your hard work on this; I think that's the last of  
>> the funky new contributed features.
>
> You're welcome, and I certainly hope so :-) I just want to see a  
> release candidate now.

Absolutely.

As I understand it, I just need to adjust the infrastructure building  
to run ./bootstrap, and then include all the new files from SVN in  
the root, along with the generated configure?

Ben