[Box Backup-dev] COMMIT r348 - in box/chris/bb-save-state: . bin/bbackupd lib/common lib/server

[Ben Summers]

On 30 Jan 2006, at 19:09, Chris Wilson wrote:

> Hi Martin,
>
>> In terms of changes still not in trunk, I don't think the type  
>> changes have been merged yet. I think Chris did fix some/all of  
>> them following review comments though. Have we a new diff to  
>> review for that one before merge?
>
> Not yet, the code doesn't pass all the unit tests. I suggest that  
> we live with the MSVC warnings for now.

Agreed.

>
>> And are some windows changes still pending?
>
> Yes, including updated project files for VS2005 as you pointed out  
> (vc2005-compile-fixes). But I'm not too bothered if they don't make  
> it into 0.10.

If they're there, why not? What's the diff to be merged?


On 30 Jan 2006, at 19:12, Chris Wilson wrote:
>
>>>  And are some windows changes still pending?
>>
>> I don't think so, unless anyone wants to fix Charles' list of  
>> Win32 issues before the release candidate.
>
> I will try, but I'm hopelessly lost with the Named Pipe ACLs. I  
> can't believe that Microsoft (a) made CreateNamedPipe insecure by  
> default, (b) did not document that fact, and (c) did not provide a  
> simple, obvious way or instructions to implement the most obvious  
> security policy, which is of course full access to the owner, no  
> access to anyone else.

I can believe it. ACLs are complex things, so the API is going to be  
tricky, I suppose. But then you want nice defaults which don't cause  
problems for developers, don't you?


Anyway, I have just committed a modified version of the Archive  
stuff. It compiles, but I haven't tested it because I'm lazy. If  
Martin thinks it's OK, let's merge it.

Ben