[Box Backup-dev] COMMIT r708 - box/chris/general/test/backupdiff

boxbackup-dev@fluffy.co.uk boxbackup-dev@fluffy.co.uk
Thu, 27 Jul 2006 22:59:43 +0000 (GMT)


Author: chris
Date: 2006-07-27 22:59:41 +0000 (Thu, 27 Jul 2006)
New Revision: 708

Modified:
   box/chris/general/test/backupdiff/testbackupdiff.cpp
Log:
* testbackupdiff.cpp
- Fixed truncate on Unix to properly create file of zeroes


Modified: box/chris/general/test/backupdiff/testbackupdiff.cpp
===================================================================
--- box/chris/general/test/backupdiff/testbackupdiff.cpp	2006-07-27 22:40:28 UTC (rev 707)
+++ box/chris/general/test/backupdiff/testbackupdiff.cpp	2006-07-27 22:59:41 UTC (rev 708)
@@ -74,29 +74,13 @@
 	TEST_THAT(SetEndOfFile(handle) == true);
 	TEST_THAT(CloseHandle(handle)  == true);
 	#else
-	TEST_THAT(truncate(filename, size) == 0);
+	int fd = open(filename, O_WRONLY | O_CREAT | O_EXCL, 0600);
+	if (fd < 0) perror(filename);
+	TEST_THAT(fd >= 0);
+	TEST_THAT(ftruncate(fd, size) == 0);
+	TEST_THAT(close(fd) == 0);
 	#endif
 
-	/*
-	static const size_t bs = 0x10000;
-	size_t remSize = size;
-	void *b = malloc(bs);
-	memset(b, 0, bs);
-	FILE *f = fopen(filename, "wb");
-	TEST_THAT(f != NULL);
-
-	// Using largish blocks like this is much faster, while not consuming too much RAM
-	while(remSize > bs)
-	{
-		fwrite(b, bs, 1, f);
-		remSize -= bs;
-	}
-	fwrite(b, remSize, 1, f);
-
-	fclose(f);
-	free(b);
-	*/
-
 	TEST_THAT((size_t)TestGetFileSize(filename) == size);
 }