[Box Backup-dev] Makefile.extra?
James O'Gorman
boxbackup-dev@fluffy.co.uk
Thu, 02 Mar 2006 18:50:09 +0000
Martin Ebourne wrote:
> I've been thinking about this, and substituting all the Makefile.extras
> is unnecessary. Instead just change them in place to use $(PERL). Then
> change makebuildenv.pl to write PERL = /.../perl into the Makefiles when
> it generates them. That will reduce the impact of this change quite a
> bit.
Hmm, yeah, that makes a lot more sense. Would the PERL variable have to
be set in each module's Makefile then? (i.e. do they not inherit from
Makefile in the root?)
> Also you've still got one cpp file being substituted:
> test/backupstorefix/testbackupstorefix.cpp.in
It's not, I just forgot to take it out of the shell script, sorry.
The patch for the cpp file is still valid though, as it replaces
'::system("perl' with '::system(PERL_EXECUTABLE "'.
> Apart from that, it all looks correct to me. I don't really like having
> all those files substituted, but can't think of a better way. If you can
> make those fixes & assuming Ben's happy with it then I'll commit the
> change.
Excellent :-)
James