[Box Backup-dev] "setlimit 0 (...) back with vengeance (Was: Proposal (patch): bbstored HousekeepingStyle mod)

[Chris Wilson]

Hi Gary,

On Tue, 23 Jan 2007, G. wrote:

> Hi ladies and gents,
>
> Unfortunately, the "bbstoreaccounts setlimit <account> 0M <hard-limit>" 
> issue (setting the soft-limit to the special value of 0) is back with 
> vengeance. I just switched my bbstored server from i686 (Intel Xeon) to 
> AMD64 (AMD Opteron), and the o/s from CentOS 4 to Ubuntu 6.06, and 
> backups no longer complete. bbstored reports:
>
> Exceeded storage limits on server -- not uploading changes to files

Yes, I hadn't thought about that, but it will do that.

> So, it looks like we are back to square one, with the following 
> alternatives:
>
> 1. Review bbstored and bbackupd code to verify correct interpretation of 
>    the 0 soft-limit special case, or:

This is a client-side problem. We should probably treat a limit of zero as 
a special case on the client, and ignore it, trying to stay below the hard 
limit instead in this case. In fact, we shouldn't even be able to exceed 
the hard limit, so this should be very easy to implement.

I'm very slightly against modifying bbstored's housekeeping in this case, 
since it requires more work than modifying bbackupd's store full logic. 
But I don't have strong feelings about it.

Cheers, Chris.
-- 
_ ___ __     _
  / __/ / ,__(_)_  | Chris Wilson <0000 at qwirx.com> - Cambs UK |
/ (_/ ,\/ _/ /_ \ | Security/C/C++/Java/Perl/SQL/HTML Developer |
\ _/_/_/_//_/___/ | We are GNU-free your mind-and your software |