[Box Backup-dev] Re: [Box Backup] ChrisMerge_1828

[Chris Wilson]

Hi James,

> On Fri, Sep 14, 2007 at 09:55:00PM +0100, Chris Wilson wrote:
>>  Looks great to me. Maybe worth sending the details of the message type to
>>  the log as well?
>
> Meaning "store-full", "read-error" or "unknown"? (i.e. the arguments
> passed to the script.)

Yes.

>>  Also, I reckon it should be:
>>
>>  * an error if the message was not sent; otherwise
>>  * nothing if the message was "backup-start" or "backup-finish"; or
>
> The script currently only checks for the three above, as per the sh
> version so it won't anyway. Is there anything else that needs to be
> checked for?

Yes, the two messages above are sent at the start and end of each backup 
run, in recent versions. I've implemented a little code to ignore them in 
the version I checked in to CVS, but I have no idea if it's correct, not 
tested yet.

> OK, I'll do that.

Thanks for your help!

Cheers, Chris.
-- 
_____ __     _
\  __/ / ,__(_)_  | Chris Wilson <0000 at qwirx.com> - Cambs UK |
/ (_/ ,\/ _/ /_ \ | Security/C/C++/Java/Perl/SQL/HTML Developer |
\ _/_/_/_//_/___/ | We are GNU-free your mind-and your software |