[Box Backup-dev] Re: [Box Backup] boxbackup 0.11rc1 - Apple PPC G4 450 Mhz - Debian Etch (stable)

Martin Ebourne boxbackup-dev@fluffy.co.uk
Wed, 06 Feb 2008 09:50:33 +0000


On Sun, 2008-01-20 at 15:09 +0000, Chris Wilson wrote:
> The current criteria is 20 seconds and your machine took 58. 30 seconds 
> would not have been enough for the test to pass for you, and I don't know 
> how long it took before the bug was fixed that caused this test to be 
> created in the first place. I do know that it takes more than 20 and 
> less than 40 seconds in a VMware vm on my laptop. 
> 
> Anyone else have suggestions for a sane time threshold for this test 
> (diffing 200MB of zeroes), taking into account that any choice will be a 
> tradeoff between old hardware and detecting inefficient code, the original 
> purpose of the test?

Ditch the test, timing related tests are never going to be portable and
I doubt it really adds anything useful to the suite.

[If the test is useful even without the timing constraint but might hang
in the event of a bug, change the time limit to be timeout and make it
very long, eg. 5-10mins.]

Cheers,

Martin.