[Box Backup] I have the fear....

[Chris Wilson]

Hi all,

> Sorry, I appear to have confused people... then gone off the air for a
> while (nice weather, kids, playground, etc.).

I understand, don't worry :-) Thanks for getting back to us.

>>> OK, so it appears that Box Backup did not notice that 
>>> ._cfg0000_host.conf was moved over host.conf, and therefore did not 
>>> back up host.conf again, until you touched the file. Is that your 
>>> understanding as well?
>
> I don't think that is the case... I just did another emerge and I see:
>
> # ls -la ntp-client ._cfg0000_ntp-client
> -rw-r--r-- 1 root root 542 Mar 13 15:15 ._cfg0000_ntp-client
> -rw-r--r-- 1 root root 745 Mar 13 15:15 ntp-client
>
> So it doesn't touch the original.

Yep, it doesn't for me either.

> I think something went wonky at step 3, but I don't know why.

Sorry, what is step 3 in this case?

> For some reason it made a backup with the contents of the original 
> version of the file, not the new ones.  It saw a change had occurred and 
> made a new version, but it was identical to the old version.

I don't understand that, are you sure?

I think I may have found another bug that may explain this. When deciding 
whether or not to upload a file, we check whether it was modified between 
mSyncPeriodStart and mSyncPeriodEnd. For a rename over another file, this 
might not be true (the original might have been modified before 
mSyncPeriodStart).

I propose that we remove this check for now. Any objections?

Cheers, Chris.
-- 
_____ __     _
\  __/ / ,__(_)_  | Chris Wilson <0000 at qwirx.com> - Cambs UK |
/ (_/ ,\/ _/ /_ \ | Security/C/C++/Java/Perl/SQL/HTML Developer |
\ _/_/_/_//_/___/ | We are GNU-free your mind-and your software |