[Box Backup] 0.11rc2 - logic error in autoconf

Mitja Muženič boxbackup@fluffy.co.uk
Mon, 11 Feb 2008 23:18:52 +0100


Hi!

While testing 0.11rc2 on OpenBSD/i386 I noticed that the logic criteria for
"__syscall needing definition" configure test were inverted. This test was
never executed during configure and because of that, the regress tests
failed in intercept.cpp.

The following patch fixes that:

--- infrastructure/m4/ax_func_syscall.m4.orig   Tue Feb 12 00:11:49 2008
+++ infrastructure/m4/ax_func_syscall.m4        Tue Feb 12 00:12:19 2008
@@ -16,8 +16,8 @@
 AC_DEFUN([AX_FUNC_SYSCALL], [
   AC_CHECK_HEADERS([sys/syscall.h unistd.h])
   AC_CHECK_FUNCS([syscall __syscall])
-  if test "x$ac_cv_func_syscall" != "xyes" &&
-     test "x$ac_cv_func___syscall" != "xyes"; then
+  if test "x$ac_cv_func_syscall" = "xyes" &&
+     test "x$ac_cv_func___syscall" = "xyes"; then
     AC_CACHE_CHECK([for __syscall needing definition],
[have___syscall_need_defn],
       [AC_RUN_IFELSE([AC_LANG_PROGRAM([[
           $ac_includes_default

(regenerate configure after applying)


Regards, Mitja