[Box Backup] Compile Error on OpenBSD 4.4 AMD64

Chris Wilson boxbackup@boxbackup.org
Mon, 27 Oct 2008 08:23:08 +0000 (GMT)


  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

---128931150-1723211684-1225095788=:957
Content-Type: TEXT/PLAIN; charset=iso-8859-2
Content-Transfer-Encoding: QUOTED-PRINTABLE

Hi Mitja,

On Mon, 27 Oct 2008, Mitja Mu=BEeni=E8 wrote:

> > Thank you all for your help. I believe I have fixed the problem in the=
=20
> > trunk and I'd appreciate your help testing it, if you have time.
>=20
> Chris, have you seen this?
>=20
> -----Original Message----- While testing 0.11rc2 on OpenBSD/i386 I=20
> noticed that the logic criteria for "__syscall needing definition"=20
> configure test were inverted. This test was never executed during=20
> configure and because of that, the regress tests failed in=20
> intercept.cpp.
>=20
> The following patch fixes that:
>=20
> --- infrastructure/m4/ax_func_syscall.m4.orig   Tue Feb 12 00:11:49 2008
> +++ infrastructure/m4/ax_func_syscall.m4        Tue Feb 12 00:12:19 2008
> @@ -16,8 +16,8 @@
>  AC_DEFUN([AX_FUNC_SYSCALL], [
>    AC_CHECK_HEADERS([sys/syscall.h unistd.h])
>    AC_CHECK_FUNCS([syscall __syscall])
> -  if test "x$ac_cv_func_syscall" !=3D "xyes" &&
> -     test "x$ac_cv_func___syscall" !=3D "xyes"; then
> +  if test "x$ac_cv_func_syscall" =3D "xyes" &&
> +     test "x$ac_cv_func___syscall" =3D "xyes"; then

No, I'd forgotten all about that. I also can't see a reply, so I guess=20
we dropped the ball on that one :(

It was half the problem, but I don't believe it was a complete solution=20
because the test really was designed to run if syscall had _not_ been=20
detected by configure. However, I think the test was based on a=20
mistaken/outdated assumption about how the standard configure test works,=
=20
which failed on that platform.

My change is bigger than the one you proposed and I believe that it fixes=
=20
the problem properly, although I'd appreciate your help testing it.

Cheers, Chris.
--=20
_____ __     _
\  __/ / ,__(_)_  | Chris Wilson <0000 at qwirx.com> - Cambs UK |
/ (_/ ,\/ _/ /_ \ | Security/C/C++/Java/Ruby/Perl/SQL Developer |
\ _/_/_/_//_/___/ | Stop nuclear war http://www.nuclearrisk.org |
---128931150-1723211684-1225095788=:957--