[Box Backup-dev] COMMIT r464 - box/trunk/lib/backupclient

[Ben Summers]

Can we have a policy on this type of thing?

Any non-optimal solution or something which should be addressed in  
the future should have a comment like

   // TODO: Added errno!=EACCES for XFS, not a good solution as read  
errors not notified properly, see SVN log

The "TODO:" bit is the marker to grep for.

Ta.

Ben




On 17 Feb 2006, at 02:26, subversion@fluffy.co.uk wrote:

> Author: martin
> Date: 2006-02-17 02:26:35 +0000 (Fri, 17 Feb 2006)
> New Revision: 464
>
> Modified:
>    box/trunk/lib/backupclient/BackupClientFileAttributes.cpp
> Log:
> On XFS the file permissions appear to apply also to the extended  
> attribute data. ie. If a file is not readable then nor is the  
> extended attribute data - even if there isn't any this is still an  
> error.
>
> This is not an ideal fix for this problem. Really we should notify  
> a read-error as we do for file read permission problems and  
> continue, but the BackupClientFileAttributes code is called from  
> multiple locations and it is not clear that it could always report  
> the error in such a way, nor even continue. This alternative is  
> better than aborting the whole run. In the case where a file isn't  
> readable this will be found and reported elsewhere anyway.
>
>
> Modified: box/trunk/lib/backupclient/BackupClientFileAttributes.cpp
> ===================================================================
> --- box/trunk/lib/backupclient/BackupClientFileAttributes.cpp	 
> 2006-02-15 00:06:22 UTC (rev 463)
> +++ box/trunk/lib/backupclient/BackupClientFileAttributes.cpp	 
> 2006-02-17 02:26:35 UTC (rev 464)
> @@ -555,7 +555,7 @@
>
>  			outputBlock.ResizeBlock(xattrSize);
>  		}
> -		else if(listSize<0 && errno!=EOPNOTSUPP)
> +		else if(listSize<0 && errno!=EOPNOTSUPP && errno!=EACCES)
>  		{
>  			THROW_EXCEPTION(CommonException, OSFileError);
>  		}
>
> _______________________________________________
> Boxbackup-dev mailing list
> Boxbackup-dev@fluffy.co.uk
> http://lists.warhead.org.uk/mailman/listinfo/boxbackup-dev