[Box Backup] Bug fix - don't die on lstat failure

Nick Knight boxbackup@fluffy.co.uk
Tue, 14 Dec 2004 09:35:05 -0000

>From reading the docs on lstat and linux lfs when the compiler flags are
used to enable large file support this switches calls to the 64 bit
versions (lstat64).

Although in my experience if a bad lstat is called fro whatever reason
then the backup will die, I second a fix to make the lstat more like a
bad read...


-----Original Message-----
From: boxbackup-admin@fluffy.co.uk [mailto:boxbackup-admin@fluffy.co.uk]
On Behalf Of Ben Summers
Sent: 13 December 2004 18:23
To: boxbackup@fluffy.co.uk
Subject: Re: [Box Backup] Bug fix - don't die on lstat failure

On 13 Dec 2004, at 18:12, Joe Krahn wrote:

> I found why I had problems getting my home directory backed up.
> If bbackupd get a bad result of lstat(), it aborts.
> In my case, the problem is actually from having a DVD .ISO file.
> Files greater than 4GB in size fail with stat; they need stat64.
> So, stat64() support is worth adding.
> But, it should also not abort the whole backup run due to one bad stat

> call. It's better to just skip the item for which fstat failed by=20
> chaning BackupClientDirectoryRecord.cpp from:

Isn't enabling linux LFS supposed to make it call that function instead=20
of lstat itself?

Failures reading a file don't cause the backup to abort, but it does=20
assume (at the moment) that getting file information is going to work.

I'll make it more tolerant.


boxbackup mailing list