[Box Backup] readline support on OS X

Martin Ebourne boxbackup@fluffy.co.uk
Thu, 16 Feb 2006 23:41:53 +0000

On Fri, 2006-02-17 at 00:39 +1100, Johan Allard wrote:
> Hi,
> After some fiddling around I managed to build readline support into  
> the default Mac OS 10.4.5 distribution. The patch to get it to work  
> is as follows (against trunk):
> Index: infrastructure/m4/vl_lib_readline.m4
> ===================================================================
> --- infrastructure/m4/vl_lib_readline.m4        (revision 463)
> +++ infrastructure/m4/vl_lib_readline.m4        (working copy)
> @@ -70,6 +70,7 @@
>     if test "x$vl_cv_lib_readline_compat_found" = "xno"; then
>       VL_LIB_READLINE_CHECK([editline],
>                             [edit editline],
> +                          [readline/readline.h],
>                            [editline/readline.h],
>                            [editline/readline.h])
>     fi


This cannot be right. You've added another parameter to a macro that
only takes four parameters. This will break something else.

Also I find it odd that an editline header should be installed in
readline/readline.h. Is it possible you have both readline and editline
available, and have managed to mix one set of headers with different

Please follow up to boxbackup-dev@fluffy.co.uk since this doesn't belong
on the main list. Also patches as attachments please, it is impossible
to apply them from inline due to whitespace getting munged.