[Box Backup] box backup and not existing directories

Torsten boxbackup@boxbackup.org
Tue, 4 Nov 2008 16:38:28 +0100


--Boundary-00=_2xGEJHbkfDbvVWq
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Hi,

if i have a location not existing locally and not existing on the store but 
activated as a location in bbackupd.conf. With this configuration box backup 
throws this errors on start.


ERROR: Failed to stat file: '/test-192.168.1.87-torsten': No such file or 
directory (2)
WARNING: Exception thrown: CommonException(OSFileError) at 
BackupClientFileAttributes.cpp(309)
ERROR: Failed to get attributes for path '/test-192.168.1.87-torsten', 
skipping location 'test-192.168.1.87-torsten'
WARNING: Failed to access directory: /test-192.168.1.87-torsten: No such file 
or directory
NOTICE: About to notify administrator about event backup-ok, running 
script '/root/exobackup/boxbackup/NotifySysadmin.sh backup-ok'


My problems:

- this errors are only printed once. The next backup runs do not consider to 
backup this location. That is not good for me. I have locations on remote 
storage mounted via samba. So only one mount error and i will never again be 
notified that this location is not backed up.

- is this the right behavior, that backup-ok is called even though there was 
this error?

I attached a little patch that makes box backup to retry this location. But i 
dont think that this is a clean way. 

Can anybody help me with this?

Thank you
  Torsten

--Boundary-00=_2xGEJHbkfDbvVWq
Content-Type: text/x-diff;
  charset="iso 8859-15";
  name="bb_retry_dir_not_existing.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename="bb_retry_dir_not_existing.diff"

Index: bin/bbackupd/BackupDaemon.cpp
===================================================================
--- bin/bbackupd/BackupDaemon.cpp	(Revision 2373)
+++ bin/bbackupd/BackupDaemon.cpp	(Arbeitskopie)
@@ -1676,7 +1676,7 @@
 						"for path '" << apLoc->mPath
 						<< "', skipping location '" <<
 						apLoc->mName << "'");
-					continue;
+					//continue;
 				}
 				
 				// Execute create directory command

--Boundary-00=_2xGEJHbkfDbvVWq--